Support SSE 4.2 for the Singlepass compiler #2775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tween different simd instruction sets. Partial work on supporting SSE4.2
…s. Added >= SSE 4.1 implementation for emit_vblendvpd. Added some TODOs
ptitSeb
reviewed
Jan 31, 2022
…ns. Changed the roundss/sd function
|
bors try |
|
Can you rebase or merge your branch with current source code? The issue with the windows test has been fixed on master. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 17, 2022
2775: Support SSE 4.2 for the Singlepass compiler r=ptitSeb a=batconjurer Closes #2767 # Description This PR adds support for the SSE 4.2 instruction set in the singlepass compiler. Previously, only AVX was supported. This implementation may also work for SSE 4.1, but this should be double checked. It does use the `blendvps` instruction indroduced in SSE 4.1, so it cannot support any earlier SSE versions at present for sure. The following are the main changes: - The assembler has changed from a Vec<X64Relocation> to a struct containing this as well as the corresponding CPU feature (indicating AVX/SSE4.2/...) - A set of SSE function macros have been added. To handle non-destructive operations, additional moves may be made before executing the corresponding SSE instruction if `src1 != dst` - A minor change to the `EmitterX64` trait. It now has a function for returning a possible CPU feature. - The implementation of `EmitterX64` for the assembler has obviously changed. It chooses the emitted assembly based on the CPU feature. Co-authored-by: R2D2 <[email protected]> Co-authored-by: Jacob Turner <[email protected]>
|
Build failed: |
|
sorry, code linter is complaining. you need to run |
|
bors r+ |
ptitSeb
added a commit
that referenced
this pull request
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2767
Description
This PR adds support for the SSE 4.2 instruction set in the singlepass compiler. Previously, only AVX was supported. This implementation may also work for SSE 4.1, but this should be double checked. It does use the
blendvpsinstruction indroduced in SSE 4.1, so it cannot support any earlier SSE versions at present for sure.The following are the main changes:
src1 != dstEmitterX64trait. It now has a function for returning a possible CPU feature.EmitterX64for the assembler has obviously changed. It chooses the emitted assembly based on the CPU feature.